Skip to content

[PM-29232] Supporting changes for cookie acquisition#820

Draft
coroiu wants to merge 4 commits intomainfrom
coroiu/PM-29232-client-add-cookie-acquisition-to-server-communication-config-service
Draft

[PM-29232] Supporting changes for cookie acquisition#820
coroiu wants to merge 4 commits intomainfrom
coroiu/PM-29232-client-add-cookie-acquisition-to-server-communication-config-service

Conversation

@coroiu
Copy link
Contributor

@coroiu coroiu commented Mar 6, 2026

🎟️ Tracking

📔 Objective

  • New get_cookies function which moves "needs_bootstrap -> acquire_cookie" logic into the SDK. In other words the client no longer needs to check if it needs to acquire a new cookie, the SDK will do that.
    • Clients can still manually call acquire_cookie when they receive redirects
  • New version of set_communication_type which doesn't take a domain/hostname

🚨 Breaking Changes

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

Logo
Checkmarx One – Scan Summary & Detailsa01a601c-e005-468e-abe9-c1f8ec3223df

Great job! No new security vulnerabilities introduced in this pull request

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 6, 2026

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

🔍 SDK Breaking Change Detection Results

SDK Version: coroiu/PM-29232-client-add-cookie-acquisition-to-server-communication-config-service (5074a3c)
Completed: 2026-03-06 14:46:43 UTC
Total Time: 279s

Client Status Details
typescript ✅ No breaking changes detected TypeScript compilation passed with new SDK version - View Details

Breaking change detection completed. View SDK workflow

@codecov
Copy link

codecov bot commented Mar 6, 2026

Codecov Report

❌ Patch coverage is 83.82838% with 49 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.84%. Comparing base (f8a75af) to head (5074a3c).

Files with missing lines Patch % Lines
...uniffi/src/platform/server_communication_config.rs 0.00% 23 Missing ⚠️
...den-server-communication-config/src/wasm/client.rs 0.00% 20 Missing ⚠️
...ver-communication-config/src/wasm/js_repository.rs 0.00% 4 Missing ⚠️
...r-communication-config/src/wasm/js_platform_api.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #820      +/-   ##
==========================================
+ Coverage   81.77%   81.84%   +0.06%     
==========================================
  Files         344      344              
  Lines       41116    41351     +235     
==========================================
+ Hits        33623    33844     +221     
- Misses       7493     7507      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant