[PM-33061] Tax Id Should Be Added When Upgrading to Teams or Enterprise#7131
Merged
sbrown-livefront merged 20 commits intomainfrom Mar 9, 2026
Merged
Conversation
Contributor
|
New Issues (2)Checkmarx found the following issues in this Pull Request
Fixed Issues (3)Great job! The following issues were fixed in this Pull Request
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7131 +/- ##
==========================================
+ Coverage 57.06% 57.07% +0.01%
==========================================
Files 2028 2028
Lines 88774 88794 +20
Branches 7913 7914 +1
==========================================
+ Hits 50656 50683 +27
+ Misses 36287 36280 -7
Partials 1831 1831 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
amorask-bitwarden
previously approved these changes
Mar 4, 2026
Contributor
amorask-bitwarden
left a comment
There was a problem hiding this comment.
Looks great - thank you.
src/Core/Billing/Premium/Commands/UpgradePremiumToOrganizationCommand.cs
Outdated
Show resolved
Hide resolved
amorask-bitwarden
previously approved these changes
Mar 4, 2026
amorask-bitwarden
approved these changes
Mar 9, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-33061
📔 Objective
Adds tax id during the upgrade from a Premium account to an Organization account. The changes ensure that tax IDs are attached to customers including special handling for Spanish NIFs.
Billing Address & Tax ID Handling
BillingAddressproperty inUpgradePremiumToOrganizationRequestand related tests was updated to use the more detailedCheckoutBillingAddressRequesttype, enabling support for tax IDs.Stripe Tax Logic
TaxExemptstatus toReverseif the billing country is not the US, orNoneif it is, and adds the provided tax ID to Stripe for accurate tax calculation.Note: Related to bitwarden/clients#19347 changes (This should be merged first if not at the same time).
📸 Screenshots
Screen.Recording.2026-03-03.at.2.03.01.PM.mov
Screen.Recording.2026-03-03.at.2.00.50.PM.mov