[PM-32829] Cipher Key for unassigned ciphers#7164
[PM-32829] Cipher Key for unassigned ciphers#7164nick-livefront wants to merge 2 commits intomainfrom
Conversation
shane-melton
left a comment
shane-melton
left a comment
There was a problem hiding this comment.
We should also update CipherOrganizationDetailsReadByIdQuery.cs that is also missing the Key mapping
| CreationDate = c.CreationDate, | ||
| RevisionDate = c.RevisionDate, | ||
| DeletedDate = c.DeletedDate, | ||
| Key = c.Key, |
There was a problem hiding this comment.
🎨 Reprompt is also not being mapped/grabbed here.
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7164 +/- ##
==========================================
+ Coverage 56.66% 60.96% +4.29%
==========================================
Files 2024 2028 +4
Lines 88602 88831 +229
Branches 7905 7917 +12
==========================================
+ Hits 50205 54153 +3948
+ Misses 36571 32763 -3808
- Partials 1826 1915 +89 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
There was a problem hiding this comment.
👍 Thanks for the tests as always!
2 participants
🎟️ Tracking
PM-32829
📔 Objective
Return the cipher key when fetching ciphers by the organization for EF, without the key SDK decryption fails.
📸 Screenshots
Screen.Recording.2026-03-05.at.2.55.26.PM.mov
Screen.Recording.2026-03-05.at.3.52.44.PM.mov