Example sync code#7172
Draft
eliykat wants to merge 1 commit intotools/PM-31885-SendControls-Policyfrom
Draft
Conversation
eliykat
commented
Mar 7, 2026
Comment on lines
+41
to
+45
| // Optimization: DisableSendPolicy.Enabled maps to SendControlsPolicy.Data.DisableSend - so we can use that | ||
| // as a proxy for that legacy policy state | ||
| sendControlsPolicy.Enabled = postUpsertedPolicyState.Enabled || | ||
| sendControlsPolicyData.DisableSend; | ||
|
|
Member
Author
There was a problem hiding this comment.
This optimization is not required if it's confusing. It could just follow the exact same pattern as the other file.
|
Contributor
|
New Issues (1)Checkmarx found the following issues in this Pull Request
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
📔 Objective
Example code for @harr1424
📸 Screenshots