Skip to content

[PM-32666] Fixes endpoint issue where you can update another by providing a valid org ID #7185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JaredScar wants to merge 2 commits into
base: main
Choose a base branch
from
+27 −0
Open

[PM-32666] Fixes endpoint issue where you can update another by providing a valid org ID #7185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd46e38
fix(controller): add null check for provider organization ID in Provi…
JaredScar Mar 9, 2026
52e5172
feat(tests): add test for updating provider organization with differe…
JaredScar Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/Api/AdminConsole/Controllers/ProviderClientsController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,11 @@ public async Task<IResult> UpdateAsync(
return Error.NotFound();
}

if (providerOrganization.ProviderId != provider.Id)
{
return Error.NotFound();
}

var clientOrganization = await organizationRepository.GetByIdAsync(providerOrganization.OrganizationId);

if (clientOrganization is not { Status: OrganizationStatusType.Managed })
Expand Down
22 changes: 22 additions & 0 deletions test/Api.Test/AdminConsole/Controllers/ProviderClientsControllerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ public async Task UpdateAsync_ServiceUserMakingPurchase_Unauthorized(
organization.Seats = 10;
organization.Status = OrganizationStatusType.Managed;
requestBody.AssignedSeats = 20;
providerOrganization.ProviderId = provider.Id;

ConfigureStableProviderServiceUserInputs(provider, sutProvider);

Expand All @@ -128,6 +129,26 @@ public async Task UpdateAsync_ServiceUserMakingPurchase_Unauthorized(
AssertUnauthorized(result, message: "Service users cannot purchase additional seats.");
}

[Theory, BitAutoData]
public async Task UpdateAsync_ProviderOrganizationBelongsToDifferentProvider_NotFound(
Provider provider,
Guid providerOrganizationId,
UpdateClientOrganizationRequestBody requestBody,
ProviderOrganization providerOrganization,
SutProvider<ProviderClientsController> sutProvider)
{
ConfigureStableProviderServiceUserInputs(provider, sutProvider);

providerOrganization.ProviderId = Guid.NewGuid();

sutProvider.GetDependency<IProviderOrganizationRepository>().GetByIdAsync(providerOrganizationId)
.Returns(providerOrganization);

var result = await sutProvider.Sut.UpdateAsync(provider.Id, providerOrganizationId, requestBody);

AssertNotFound(result);
}

[Theory, BitAutoData]
public async Task UpdateAsync_Ok(
Provider provider,
Expand All @@ -141,6 +162,7 @@ public async Task UpdateAsync_Ok(
organization.Seats = 10;
organization.Status = OrganizationStatusType.Managed;
requestBody.AssignedSeats = 20;
providerOrganization.ProviderId = provider.Id;

ConfigureStableProviderServiceUserInputs(provider, sutProvider);

Expand Down
Loading