Open
Conversation
|
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
Contributor
|
@sbrown-livefront You've got some failing tests on here. Wanna take care of those before I review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-31645
📔 Objective
This pull request refactors tax exemption logic across billing-related services and validation models to centralize country determination . The main change is replacing direct country checks (previously hardcoded for the United States) with calls to the new
TaxHelpersutility. Tax exemption status is now consistently determined usingTaxHelpers.DetermineTaxExemptStatus, ensuring correct handling for various countries and scenarios.Bit.Core.Billing.Tax.Utilitiesimports throughout affected files to support the new utility methods.📸 Screenshots
Trigger Billing Warnings for Required TaxId When Updating Organization Billing Address
Screen.Recording.2026-03-06.at.5.12.32.PM.mov
No Billing Warnings for Swiss Organization When Updating Organization Billing Address
Screen.Recording.2026-03-06.at.5.14.29.PM.mov
Update Tax Exempt Status When Updating Organization Billing Address
Screen.Recording.2026-03-06.at.5.21.47.PM.mov
Update Tax Exempt Status When Upgrading Organization
Screen.Recording.2026-03-06.at.5.25.01.PM.mov
Trigger Billing Warnings for Required TaxId When Updating Provider Billing Address
Screen.Recording.2026-03-06.at.5.28.51.PM.mov
Create Client Organization With the Correct Tax Exempt Status (Provider Tax Exempt Status)
Screen.Recording.2026-03-06.at.5.41.18.PM.mov
Upcoming Invoice Handler Retains Manually Set Tax Exempt Status Swiss Organization (Works the Same for Providers)
Screen.Recording.2026-03-09.at.2.31.22.PM.mov
Upcoming Invoice Handler Correctly Sets Tax Exempt Status For International Organization (Works the Same for Providers)
Screen.Recording.2026-03-09.at.2.35.39.PM.mov