Skip to content

Ac/pm 33040/add new cache interface methods#7187

Open
JimmyVo16 wants to merge 2 commits intomainfrom
ac/pm-33040/add-new-cache-interface-methods
Open

Ac/pm 33040/add new cache interface methods#7187
JimmyVo16 wants to merge 2 commits intomainfrom
ac/pm-33040/add-new-cache-interface-methods

Conversation

@JimmyVo16
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-33040

📔 Objective

  1. Add new interface methods to support a pattern where we pass only the desired IDs instead of retrieving all resources from the cache.
  2. Add unit tests.

📸 Screenshots

The code is not being used anywhere, so no manual testing is required.

@JimmyVo16 JimmyVo16 requested a review from jrmccannon March 9, 2026 19:25
@JimmyVo16 JimmyVo16 self-assigned this Mar 9, 2026
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 9, 2026

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2026

Logo
Checkmarx One – Scan Summary & Details1e301661-e5ba-4437-9b54-5965dcc905ae

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Mar 9, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.07%. Comparing base (4732d7f) to head (cbf6ad1).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...Implementations/InMemoryApplicationCacheService.cs 0.00% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7187      +/-   ##
==========================================
- Coverage   57.08%   57.07%   -0.01%     
==========================================
  Files        2028     2028              
  Lines       88794    88826      +32     
  Branches     7914     7914              
==========================================
+ Hits        50684    50699      +15     
- Misses      36279    36296      +17     
  Partials     1831     1831              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant