Fix unkillable test jobs while waiting for dependencies #47
Conversation
When a test job was waiting for its dependencies to complete (in `await_dep_success`), it did not monitor its cancellation token. This meant that if the process received a SIGINT (Ctrl+C), the waiting job would continue to block until all its dependencies finished (or timed out after their own grace period). This commit modifies `await_dep_success` to use `tokio::select!` and race the dependency completion against the cancellation token. If the token is cancelled, the wait is aborted immediately, returning `TestInconclusive::Canceled`. This ensures that the `limmat` process can shut down more responsively, even if dependency jobs are taking time to clean up. Wait logic in `await_dep_success` was refactored to return `Result<DepDatabaseEntries, DepWaitError>` to differentiate between dependency failure and cancellation. Added a regression test `should_cancel_waiting_for_deps` which simulates a slow-to-cancel dependency and asserts that the waiting job cancels immediately. Fixes #36
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Fix unkillable test jobs while waiting for dependencies
PR created automatically by Jules for task 17802188835108785854 started by @bjackman