Fix Windows OS build compatibility issues with CMake, DLL exports, header conflicts, linking, and header organization

.github/workflows/ci.yml

@@ -60,6 +60,10 @@ jobs:
         run: |
           choco install ninja
 
+      - name: Setup MSVC Developer Command Prompt (Windows)
+        if: runner.os == 'Windows'
+        uses: ilammy/msvc-dev-cmd@v1
+
       - name: Setup CMake and vcpkg
         uses: lukka/get-cmake@latest
 
@@ -84,7 +88,7 @@ jobs:
       - name: Test library linkage (Windows)
         if: runner.os == 'Windows'
         run: |
-          cd bin/build/${{ env.PRESET_NAME }}/example/${{ matrix.build_type }}
+          cd bin/build/${{ env.PRESET_NAME }}/example
           dir
 
       - name: Upload build artifacts

CMakeLists.txt

@@ -13,10 +13,19 @@ set(CMAKE_CXX_STANDARD_REQUIRED ON)
 set(CMAKE_INSTALL_RPATH_USE_LINK_PATH TRUE)
 if(APPLE)
     set(CMAKE_INSTALL_RPATH "@loader_path/../lib")
+elseif(WIN32)
+    # On Windows, DLLs are found via PATH or same directory as executable
+    set(CMAKE_INSTALL_RPATH "")
 endif()
 
 # Options
 option(BINANCECPP_BUILD_EXAMPLES "Build examples" ON)
+option(BINANCECPP_DEPLOY_MODE "Enable deployment mode, disables examples" OFF)
+
+# Deployment mode overrides examples setting
+if(BINANCECPP_DEPLOY_MODE)
+    set(BINANCECPP_BUILD_EXAMPLES OFF CACHE BOOL "Deploy mode disables examples" FORCE)
+endif()
 
 
 # Find packages

CMakePresets.json

@@ -50,26 +50,32 @@
             "name": "windows-debug",
             "inherits": "debug",
             "displayName": "Windows Debug",
-            "description": "Debug Windows build using vcpkg with Visual Studio",
-            "generator": "Visual Studio 17 2022",
-            "architecture": "x64",
+            "description": "Debug Windows build using vcpkg with Ninja and MSVC",
+            "generator": "Ninja",
             "condition": {
                 "type": "equals",
                 "lhs": "${hostSystemName}",
                 "rhs": "Windows"
+            },
+            "cacheVariables": {
+                "CMAKE_CXX_COMPILER": "cl.exe",
+                "CMAKE_C_COMPILER": "cl.exe"
             }
         },
         {
             "name": "windows-release",
             "inherits": "release",
             "displayName": "Windows Release",
-            "description": "Release Windows build using vcpkg with Visual Studio",
-            "generator": "Visual Studio 17 2022",
-            "architecture": "x64",
+            "description": "Release Windows build using vcpkg with Ninja and MSVC",
+            "generator": "Ninja",
             "condition": {
                 "type": "equals",
                 "lhs": "${hostSystemName}",
                 "rhs": "Windows"
+            },
+            "cacheVariables": {
+                "CMAKE_CXX_COMPILER": "cl.exe",
+                "CMAKE_C_COMPILER": "cl.exe"
             }
         },
         {
@@ -132,13 +138,16 @@
             "name": "windows-deploy",
             "inherits": "deploy",
             "displayName": "Windows Deploy",
-            "description": "Production Windows deployment build without examples",
-            "generator": "Visual Studio 17 2022",
-            "architecture": "x64",
+            "description": "Production Windows deployment build without examples using Ninja and MSVC",
+            "generator": "Ninja",
             "condition": {
                 "type": "equals",
                 "lhs": "${hostSystemName}",
                 "rhs": "Windows"
+            },
+            "cacheVariables": {
+                "CMAKE_CXX_COMPILER": "cl.exe",
+                "CMAKE_C_COMPILER": "cl.exe"
             }
         },
         {

example/example.cpp

@@ -9,7 +9,7 @@
 #include <string_view>
 #include <vector>
 
-#include "binance_cpp.h"
+#include "binance_api.h"
 #include "binance_websocket.h"
 
 constexpr const char* API_KEY    = "api key";

example/example_aggTrades.cpp

@@ -5,7 +5,7 @@
 #include <string>
 #include <vector>
 
-#include "binance_cpp.h"
+#include "binance_api.h"
 #include "binance_websocket.h"
 
 std::map<long, std::map<std::string, double>> aggTradeCache;

example/example_depthCache.cpp

@@ -5,7 +5,7 @@
 #include <string>
 #include <vector>
 
-#include "binance_cpp.h"
+#include "binance_api.h"
 #include "binance_websocket.h"
 
 std::map<std::string, std::map<double, double>> depthCache;

example/example_klines.cpp

@@ -5,7 +5,7 @@
 #include <string>
 #include <vector>
 
-#include "binance_cpp.h"
+#include "binance_api.h"
 #include "binance_websocket.h"
 
 std::map<long, std::map<std::string, double>> klinesCache;

example/example_template.cpp

@@ -4,7 +4,7 @@
 
 #include <string>
 
-#include "binance_cpp.h"
+#include "binance_api.h"
 #include "binance_websocket.h"
 
 #define API_KEY "myapikey"

example/example_userStream.cpp

@@ -4,7 +4,7 @@
 #include <string>
 #include <vector>
 
-#include "binance_cpp.h"
+#include "binance_api.h"
 #include "binance_websocket.h"
 
 #define API_KEY "api key"

example/example_wapi.cpp

@@ -5,7 +5,7 @@
 #include <string>
 #include <vector>
 
-#include "binance_cpp.h"
+#include "binance_api.h"
 #include "binance_websocket.h"
 
 #define API_KEY "api key"

src/CMakeLists.txt

@@ -23,12 +23,16 @@ set_target_properties(binancecpp PROPERTIES
     EXPORT_NAME binancecpp
 )
 
+# Define export macro for Windows DLL
+target_compile_definitions(binancecpp PRIVATE BINANCECPP_EXPORTS)
+
 # Link libraries
 target_link_libraries(binancecpp
-    PRIVATE
+    PUBLIC
         JsonCpp::JsonCpp
+    PRIVATE
         CURL::libcurl
-        websockets
+        $<IF:$<TARGET_EXISTS:websockets>,websockets,websockets_shared>
 )
 
 # Include directories
@@ -43,9 +47,13 @@ target_include_directories(binancecpp
 
 # Compiler-specific options for C++20
 target_compile_options(binancecpp PRIVATE
-    -fPIC
+    # Position Independent Code for Unix systems only
+    $<$<NOT:$<PLATFORM_ID:Windows>>:-fPIC>
+    # C++20 concepts support
     $<$<CXX_COMPILER_ID:GNU>:-fconcepts>
     $<$<CXX_COMPILER_ID:Clang>:-fconcepts-ts>
+    # Windows-specific options
+    $<$<CXX_COMPILER_ID:MSVC>:/std:c++20>
 )
 
 # Add alias for consistent naming