fix: correctly escape empty shell arguments #41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
escapeShellArgutility previously returned an empty string when the input argument itself was an empty string (""). As a result, empty arguments were completely omitted from the generated command line, causing positional arguments to shift. This could silently break commands that rely on empty string placeholders.Solution
Updated
escapeShellArginpackages/core/src/utils/shell-utils.tsto explicitly handle empty string inputs. The function now returns a quoted empty string instead of yielding nothing:""for cmd''for bash / PowerShellThis ensures empty arguments are preserved correctly across all supported shells.
File Changes
packages/core/src/utils/shell-utils.tsModified
escapeShellArgto return a quoted empty string when the argument is empty.packages/core/src/utils/shell-utils.test.tsUpdated unit tests to verify that empty strings are correctly escaped and preserved for all supported shells.