Skip to content

Revert "Dev"#204

Merged
v4rgas merged 1 commit intomainfrom
revert-202-dev
Feb 28, 2025
Merged

Revert "Dev"#204
v4rgas merged 1 commit intomainfrom
revert-202-dev

Conversation

@v4rgas
Copy link
Contributor

@v4rgas v4rgas commented Feb 28, 2025

Reverts #202

@v4rgas v4rgas merged commit 3cd5d71 into main Feb 28, 2025
2 checks passed
@v4rgas v4rgas deleted the revert-202-dev branch February 28, 2025 19:26
@blar-app blar-app bot added size XL Pull Request size is Extra Large Impact S The PR impact is low labels Feb 28, 2025
@blar-app
Copy link

blar-app bot commented Feb 28, 2025

PR Summary

This pull request reverts the changes made in a prior commit labeled "Dev", effectively reversing modifications associated with Dart language support and related components.

Key Findings

  • The import statement for DartDefinitions was removed, undoing prior changes.
  • Modifications introduced by the "Dev" commit were reversed across multiple files, including removal of the pretty_print method and related Dart language support.
  • References to Dart definitions were removed from various parts of the codebase, including the language servers initialization and the ProjectGraphCreator class.
  • Dependencies associated with Dart support were purged, including the tree-sitter-language-pack.
  • A context manager was added to the initialize_all_language_servers function, and logging within this context was enhanced.

Pull Request Impact: 11
We measure the impact of a Pull Request on the codebase by counting the number of references to the changed code.

🔄 File Changes Overview
File Description
blarify/code_hierarchy/languages/init.py Removed the import statement for 'DartDefinitions' from the file.
blarify/code_hierarchy/languages/dart_definitions.py This commit reverts a previous change labeled 'Dev', effectively undoing modifications made in that commit.
blarify/code_hierarchy/tree_sitter_helper.py The method pretty_print was removed from the file, reverting the changes made in a previous commit.
blarify/code_references/lsp_helper.py Removed imports related to Dart definitions and associated checks for Dart file extensions, indicating that support for Dart language files has been removed.
blarify/project_graph_creator.py Removed references to DartDefinitions from the import statement and the file extensions mapping in the ProjectGraphCreator class.
blarify/utils/initialize_all_language_servers.py The code change modifies the initialize_all_language_servers function to create a local variable lsp which stores an instance of SyncLanguageServer. The change also adds a context manager to start the language server, altering the logging message to occur within this context.
blarify/utils/test This commit reverts the changes made in the 'Dev' commit.
blarify/utils/test.dart Reverted a previous commit labeled 'Dev', restoring the file to its prior state before the specified changes.
blarify/utils/tree_sitter_dumper.py The changes involved reverting a previous commit labeled 'Dev', which indicates that modifications made in that commit were undone.
pyproject.toml Removed the dependency on 'tree-sitter-language-pack' from the file.
📃 Unreviewed files The following files were not reviewed by the agent:
File path
.gitignore
blarify/examples/graph_builder.py
blarify/vendor/multilspy/language_servers/omnisharp/workspace_did_change_configuration.json
poetry.lock
📊 Impact Summary This tables shows the impact of the changes in the codebase
File path Name Impact Type of impact
blarify/code_references/lsp_helper.py _get_language_definition_for_extension 2 Modified
blarify/project_graph_creator.py ProjectGraphCreator 3 Modified
blarify/utils/initialize_all_language_servers.py initialize_all_language_servers 1 Modified
blarify/examples/graph_builder.py build 1 Modified
blarify/code_hierarchy/tree_sitter_helper.py TreeSitterHelper 4 Modified
📜 Blar Instructions

Blar Commands

  • Comment -blar --review triggers a review of the Pull Request, analyzing only the unreviewed commits since the last review.
  • Comment -blar --review --force to receive a complete review of the entire Pull Request, reanalyzing all commits.
  • Make an issue comment or reply to it with -blar --add-wiki to save a code guideline rule in the wiki. It will be used to review the code with the design pattern agent 🎨

Tags Explanation

  • 🐛 Debugger Agent Issues:
    These issues are identified by our Debugger Agent, which focuses on detecting bugs and errors in your code.
    Solutions for 🐛 issues are available upon request using the -blar --fix command.

  • ⚡ Optimizer Agent Issues:
    These issues focus on identifying inefficient database queries that can impact performance.
    Solutions for ⚡ issues are available upon request using the -blar --fix command.

  • 🛡️ Cyber Security Agent Issues:
    These issues focus on identifying potential security vulnerabilities in your code.
    Solutions for 🛡️ issues are available upon request using the -blar --fix command.

  • 🎨 Design Pattern Reviewer Agent Issues:
    These issues highlight concerns related to improper or suboptimal use of design patterns, evaluated based on rules set in the wiki.
    Solutions for 🎨 issues are available upon request using the -blar --add-wiki command.

Comment on lines 59 to -63
elif extension in GoDefinitions.get_language_file_extensions():
return GoDefinitions
elif extension in DartDefinitions.get_language_file_extensions():
return DartDefinitions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Error 🐛 Bug

  • The function _get_language_definition_for_extension raises a FileExtensionNotSupported exception when provided with a Dart file extension.
  • The branch that handled Dart file extensions has been removed from the code.
  • As a result, any Dart file now results in falling through to the else clause,
  • This change indicates that Dart language support has been explicitly removed.

Code Snippet:
raise FileExtensionNotSupported(f'File extension "{extension}" is not supported)

@blar-app
Copy link

blar-app bot commented Feb 28, 2025

❕ It looks like we couldn't find any design patterns in the Wiki for this repository. Let's add some at: app.blar.io/wiki

@blar-app
Copy link

blar-app bot commented Feb 28, 2025

Did you really think deleting a branch was the solution? At this point, even a clueless Dart file knows more about support than you do!

rysweet pushed a commit to rysweet/blarify that referenced this pull request Aug 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Impact S The PR impact is low size XL Pull Request size is Extra Large

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant