Add support for page size, orientation, and image from Android assets#2
Open
esutton wants to merge 26 commits intoblink22:masterfrom
Open
Add support for page size, orientation, and image from Android assets#2esutton wants to merge 26 commits intoblink22:masterfrom
esutton wants to merge 26 commits intoblink22:masterfrom
Conversation
@esutton It would be nice if you can express how you find our update beneficial here, so Chris can merge our updates and the developers will have a central place for the library where it improves in an accumulated way. |
Author
|
@IslamSalah Sorry. I had not seen that issue. I will leave comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am a git newbie and trying to learn how to use git in public projects.
Are you taking pull requests? I made a couple of Android changes that I have tested and am using on Android.
I think it would be beneficial if your changes that removed all AGPL dependencies were added back to the original christopherdro/react-native-html-to-pdf
I think your approach is a 10x improvement over the previous AGPL lib which had sketchy CSS support and other anomalies.
Perhaps under a "version": "1.0.0-beta" version number ?
Else if christopherdro is not interested I think your improvements are very valuable to the community and are important enough to consider renaming the project and starting a new one. Thank you for sharing your work and helping others on Stack Overflow!