-
Notifications
You must be signed in to change notification settings - Fork 1
feat: update file field on assets page #888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jeremydw
commented
Jan 28, 2026
- This is a surgical update to the file field on the assets page; meant to update the field to use the new file field.
- I know we'll build out a media library one day, but this is meant to be an incremental improvement.
- Also add new options regarding the file naming.
- Add a confirm dialog for overwrites (when choosing "preserve original filename without hash").
stevenle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the new "preserve filename" option, does that apply to all file fields or is it only used by the asset page? If it's being added to all file fields I think I would prefer the options be hidden under a menu so it doesn't take up so much real estate (in most use cases people don't care about the filename preservation).
| @@ -1,15 +1,19 @@ | |||
| .FileField { | |||
| .FileField, | |||
| .FileUploader { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should include .FileUploader selectors here since it'll make it hard to find later, ideally both places would use a shared component but if this isn't feasible let's just move all the .FileUploader styles to FileUploader.css
(also for the asset page, i don't think we need the border/padding from this specific style)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah; it's just used on the asset page. there are no changes to the field within the doc editor. let me take another pass at the CSS here - the FileUploader is basically the wrapper component that's used on the asset page only. i'll change this PR from a "draft" to "ready" when it's ready for another pass.
|
lmk if this is ready for another look |
|
this more or less looks good. the code seems to indicate an error is thrown if you try to overwrite an existing file, do you care about bypassing? caching may be a concern if so. |
|
nm i just tested locally and see the overwrite prompt now. i'm thinking by default for the "clean" / original filename option we set it to nocache |






