chore: improve keyboard/find behavior in doc editor #910
+9
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Description
tabIndex={-1}inpackages/root-cms/ui/components/DocEditor/DocEditor.tsxso the#link is skipped by tab navigation.data-previewattribute (data-preview={previewText}) instead of a direct text child inDocEditor.ArrayFieldPreview.packages/root-cms/ui/components/DocEditor/DocEditor.cssthat displays the preview via.DocEditor__ArrayField__item__header__preview__title::before { content: attr(data-preview); }to preserve visual output while removing the preview from the element's text node.Testing
git diffandgit statusto verify the changes were applied and staged, which succeeded.fix(cms): improve keyboard/find behavior in doc editor, which succeeded.net::ERR_EMPTY_RESPONSE). No other automated tests were run per the request to avoid running tests unless explicitly prompted.Codex Task