This repository was archived by the owner on Aug 17, 2025. It is now read-only.
feat: image based deployment #5693
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecthomas
reviewed
Jun 5, 2025
|
|
||
| // Creates and applies a changeset, returning the result | ||
| // This blocks until the changeset has completed | ||
| rpc DeployImages(DeployImagesRequest) returns (stream DeployImagesResponse); |
Collaborator
There was a problem hiding this comment.
Nice! We can abstract the details.
I did a bit of digging into how painful it would be to create an OCI registry proxy, but it seemed...painful, so maybe this is the next best option?
Collaborator
Author
There was a problem hiding this comment.
We can also upload images as tarballs to emulate the current approach for local dev.
An OCI proxy would take some time to get right, I am going to push ahead with this approach and see how far I can take it.
stuartwdouglas
force-pushed
the
stuartwdouglas/image-based-deployments
branch
9 times, most recently
from
a7a6239 to
40bf8b8
Compare
stuartwdouglas
force-pushed
the
stuartwdouglas/image-based-deployments
branch
7 times, most recently
from
8eac780 to
2b2f090
Compare
stuartwdouglas
force-pushed
the
stuartwdouglas/image-based-deployments
branch
from
22380a6 to
923773c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an
ftl image deploycommand that can deploy from an image