-
Notifications
You must be signed in to change notification settings - Fork 2.3k
refactor: include hidden dotfiles folders in file picker search #6315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR addresses issue #6211 by enabling the file picker to include important configuration directories that start with a dot (hidden folders) in search results, making it possible to reference files like GitHub workflows and VS Code settings.
- Introduces an allowlist approach for hidden directories instead of blanket exclusion
- Removes
.vscodeand.ideafrom the skip list since they're now explicitly allowed - Updates documentation to reflect the new hidden folder support
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ui/desktop/src/components/MentionPopover.tsx | Adds allowedHiddenDirs array with configuration directories (.github, .vscode, .idea, etc.) and modifies filtering logic to check the allowlist before skipping hidden items |
| documentation/docs/guides/file-management.md | Updates file search documentation to remove .vscode and .idea from the auto-filtering list and adds a new bullet point documenting hidden folder support |
| ]; | ||
|
|
||
| // directories should be included in search | ||
| const allowedHiddenDirs = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, is there a different approach that will allow all hidden directories, not just a hardcoded list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's like we skipped some of the files, just like we did before. I am not sure if we should allow all of them
|
|
||
| // Skip hidden items except for allowed hidden directories | ||
| if (item.startsWith('.') && !allowedHiddenDirs.includes(item)) { | ||
| continue; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why skip?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just like before, we skipped some of the dotfiles and others for security purposes, like .git and system, etc if we want, we can allow all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think just include them all, as this is for when the user is selecting right?
Signed-off-by: Abhijay007 <Abhijay007j@gmail.com>
53f296a to
4296cfe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Signed-off-by: Abhijay007 <Abhijay007j@gmail.com>
closes #6211
PR description:
Refactor the file picker to include hidden configuration folders in search results. Previously, all files and folders starting with
.were excluded, making it impossible to reference important configuration files like GitHub workflows, VS Code settings, and other dotfiles.Changes made
Added allowlist for hidden directories: Created
allowedHiddenDirsarray containing important configuration directories:.github- GitHub workflows and actions.vscode- VS Code settingsetc .....
Updated filtering logic: Modified the file picker to check if hidden items are in the allowlist before skipping them, instead of blanket-excluding all dotfiles
Removed from skip list: Removed
.vscodeand.ideafromskipDirssince they're now explicitly allowedDocumentation update: Updated file management guide to document the new hidden folder support
Type of Change
Testing
Tested in the desktop UI
Screenshots/Demos (for UX changes)
Before:
After: