Skip to content

Conversation

@Abhijay007
Copy link
Collaborator

closes #6211

PR description:

Refactor the file picker to include hidden configuration folders in search results. Previously, all files and folders starting with . were excluded, making it impossible to reference important configuration files like GitHub workflows, VS Code settings, and other dotfiles.

Changes made

  • Added allowlist for hidden directories: Created allowedHiddenDirs array containing important configuration directories:

    • .github - GitHub workflows and actions
    • .vscode - VS Code settings
      etc .....
  • Updated filtering logic: Modified the file picker to check if hidden items are in the allowlist before skipping them, instead of blanket-excluding all dotfiles

  • Removed from skip list: Removed .vscode and .idea from skipDirs since they're now explicitly allowed

  • Documentation update: Updated file management guide to document the new hidden folder support

Type of Change

  • Refactor / Code quality

Testing

Tested in the desktop UI

Screenshots/Demos (for UX changes)

Before:

image

After:

image

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses issue #6211 by enabling the file picker to include important configuration directories that start with a dot (hidden folders) in search results, making it possible to reference files like GitHub workflows and VS Code settings.

  • Introduces an allowlist approach for hidden directories instead of blanket exclusion
  • Removes .vscode and .idea from the skip list since they're now explicitly allowed
  • Updates documentation to reflect the new hidden folder support

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
ui/desktop/src/components/MentionPopover.tsx Adds allowedHiddenDirs array with configuration directories (.github, .vscode, .idea, etc.) and modifies filtering logic to check the allowlist before skipping hidden items
documentation/docs/guides/file-management.md Updates file search documentation to remove .vscode and .idea from the auto-filtering list and adds a new bullet point documenting hidden folder support

];

// directories should be included in search
const allowedHiddenDirs = [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, is there a different approach that will allow all hidden directories, not just a hardcoded list?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's like we skipped some of the files, just like we did before. I am not sure if we should allow all of them


// Skip hidden items except for allowed hidden directories
if (item.startsWith('.') && !allowedHiddenDirs.includes(item)) {
continue;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why skip?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just like before, we skipped some of the dotfiles and others for security purposes, like .git and system, etc if we want, we can allow all

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think just include them all, as this is for when the user is selecting right?

Copilot AI review requested due to automatic review settings January 2, 2026 09:02
Signed-off-by: Abhijay007 <Abhijay007j@gmail.com>
@Abhijay007 Abhijay007 force-pushed the refactor/AllowedDotfiles branch from 53f296a to 4296cfe Compare January 2, 2026 09:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Signed-off-by: Abhijay007 <Abhijay007j@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@ file picker excludes hidden folders (dotfiles like .github) from search results

3 participants