Add village visualization for orchestrator dashboard, user gtwall support#2
Open
tlongwell-block wants to merge 4 commits intomainfrom
Open
Add village visualization for orchestrator dashboard, user gtwall support#2tlongwell-block wants to merge 4 commits intomainfrom
tlongwell-block wants to merge 4 commits intomainfrom
Conversation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
f7029c6 to
527b0bb
Compare
Interactive SVG village where AI delegates appear as geese walking between role-specific buildings (library for researchers, forge for generics, factory for workers, etc.) via A* pathfinding with tiered terrain costs. Includes: - Real-time SSE dashboard with delegate registry, wall feed, and workshop - ASCII map system with visual editor (editor.html) - Standalone fullscreen village page (village.html) - Map validator script with pathfinding analysis (scripts/validate-map) - Pub/sub state management, lit-html rendering, zero build step - 3 CDN deps: lit-html, marked, DOMPurify (version-pinned) Security: CSP headers, DOMPurify + lit-html auto-escaping, parameterized SQL, read-only DB, input validation, subprocess_exec (not shell). Accessibility: WCAG AA contrast, ARIA roles/states, keyboard navigation, focus trapping, prefers-reduced-motion support. Crossfire-reviewed to 9/10 by independent models.
527b0bb to
25ba01f
Compare
- Remove dead parent_session query param from SSE URL
- Math.round → Math.floor for path start tile (prevents tile jump mid-walk)
- Add aria-live/role=log to bulletin feed for screen reader announcements
- Add aria-expanded to village toggle button
- Add aria-label to wall-post textarea
- Add viewport meta to editor.html
- Fix e.target.role → getAttribute('role') for cross-browser compat
- Document CSP unsafe-inline rationale and localhost trust model
- Tighten speech bubble positioning (y=-60, closer to goose)
- Trailing newlines on HTML files
- Sort imports per biome organizeImports (editor.js, village.js) - Remove unused BUILDING_CHARS import from editor.js - Lowercase hex literal 0xFFFF → 0xffff (tiles.js) - Use template literal for string concat (village.js) - Biome check now passes clean (0 errors, 0 warnings) Crossfire: both reviewers APPROVE at 9/10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an interactive village view to the dashboard where delegates appear as geese walking between role-specific buildings. Includes a map editor, standalone fullscreen page, and a CLI map validator.
What's here
/ui/editor.htmlbuildings.jsSSOT — single table drives both village and editor; adding a building is one table entry + one SVG + one map charscripts/validate-map— A* pathfinding validator with walk-time analysis, water contiguity checks, and dead-end detectionSecurity
CSP headers, DOMPurify + lit-html auto-escaping for untrusted content, parameterized SQL with read-only DB,
subprocess_exec(not shell) for wall posts, input validation on all endpoints, SSE connection limits, config allowlisting.Accessibility
WCAG AA contrast, ARIA roles/states/properties, keyboard navigation with focus trapping,
prefers-reduced-motionsupport.Stats
~2,700 LOC across 10 new files and 8 modified. Zero build step, 3 CDN deps (lit-html, marked, DOMPurify — version-pinned).