Justin Lowry: Apple-Nav#246
Open
jlowry42 wants to merge 6 commits intobloominstituteoftechnology:masterfrom
Open
Justin Lowry: Apple-Nav#246jlowry42 wants to merge 6 commits intobloominstituteoftechnology:masterfrom
jlowry42 wants to merge 6 commits intobloominstituteoftechnology:masterfrom
Conversation
szincone
reviewed
Nov 28, 2018
szincone
left a comment
szincone
left a comment
There was a problem hiding this comment.
Really good project. The Nav bar is identical to the apple one. Code is really clean and all very efficient. I remember having to resort to a lot of 'hacky' techniques to get React-Router to work for me in the beginning and you seem to have a very strong understanding of react-router at this stage.
| import styled from 'styled-components'; | ||
| import {NavLink} from 'react-router-dom'; | ||
|
|
||
| const StyledNav = styled(NavLink)` |
There was a problem hiding this comment.
Good job incorporating styled components. I wasn't a believer in them at first but I'm a big fan now, the more I use them the more I like them.
| `; | ||
|
|
||
| const Nav = props => { | ||
| return <StyledNav to={`/${props.name}`}>{props.name}</StyledNav>; |
| render={props => <SubNav {...props} subLinks={d.subLinks} />} | ||
| /> | ||
| ))} | ||
| <h2>The Same Stuff, But Twice As Expensive!</h2> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.