Skip to content

Comments

addison stavlo#247

Open
Addison-Stavlo wants to merge 5 commits intobloominstituteoftechnology:masterfrom
Addison-Stavlo:master
Open

addison stavlo#247
Addison-Stavlo wants to merge 5 commits intobloominstituteoftechnology:masterfrom
Addison-Stavlo:master

Conversation

@Addison-Stavlo
Copy link

@Addison-Stavlo Addison-Stavlo commented Nov 28, 2018

Kamalnrf
Kamalnrf suggested changes Nov 28, 2018
View reviewed changes
Copy link

@Kamalnrf Kamalnrf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did it in a bruteforce by having a path for all sub navs instead it was to use params.
Try doing it again using params

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Kamalnrf Kamalnrf Kamalnrf requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Addison-Stavlo @Kamalnrf