🛡️ Sentinel: Fix password truncation in entrypoint script #21
Conversation
This change fixes a critical security issue where passwords containing spaces would be truncated when creating users. It also prevents globbing issues by quoting variable expansions. - Quoted `"$username"` and `"$password"` in `adduser` calls. - Added `-r` flag to `read` commands to preserve backslashes. - Verified that passphrases with spaces are now correctly handled.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
🛡️ Sentinel: [CRITICAL] Fix password truncation and command injection risks in entrypoint
🚨 Severity: CRITICAL
💡 Vulnerability: Unquoted variable expansion in
copyables/entrypoint.shcaused passwords containing spaces to be truncated (e.g., "correct horse battery staple" became "correct"). It also posed a risk of command injection/globbing if usernames contained special characters.🎯 Impact: Users setting strong passphrases would silently end up with weak passwords (the first word only).
🔧 Fix:
$usernameand$passwordvariables inaddusercalls.read -rto prevent backslash interpretation.✅ Verification: Verified with a reproduction script that spaces in passwords are now preserved correctly.
PR created automatically by Jules for task 4389350057758254233 started by @bluPhy