🛡️ Sentinel: [MEDIUM] Fix globbing injection and command iteration bug

[google-labs-jules]

🛡️ Sentinel: [MEDIUM] Fix globbing injection and command iteration bug

🚨 Severity: MEDIUM
💡 Vulnerability: Shell Globbing Injection & Logic Bug

• Logic Bug: The entrypoint script failed to iterate over multiple semicolon-separated commands in VPNCMD_SERVER and VPNCMD_HUB. Only the first command was executed due to incorrect array access.
• Security Issue: Dynamic commands were executed with unquoted variable expansion, allowing shell globbing. If a command contained * (e.g., LogDisable *), it could expand to filenames in the working directory, potentially causing unexpected behavior or errors.

🎯 Impact:

• Configuration commands might be silently ignored.
• Potential for unintended arguments being passed to vpncmd if files match the glob pattern.

🔧 Fix:

• Updated the loop to correctly iterate over all commands in the array.
• Wrapped the command execution in set -f / set +f to disable globbing while preserving word splitting for arguments.

✅ Verification:

• Added tests/test_entrypoint_logic.sh which mocks the environment and verifies that:
  1. Multiple commands are executed.
  2. Wildcards are passed literally and not expanded.

---

PR created automatically by Jules for task 15814255171167426889 started by @bluPhy

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[coderabbitai]

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}