🛡️ Sentinel: Fix insecure variable expansion and command injection risks

[google-labs-jules]

🛡️ Sentinel: [CRITICAL/HIGH] Fix insecure variable expansion

Severity: HIGH

Vulnerability:

1. Credential Truncation: Unquoted variables in entrypoint.sh caused passwords with spaces to be truncated or expanded unexpectedly.
2. Command Injection/Globbing: Dynamic execution of VPNCMD_* environment variables was subject to shell globbing and failed to execute multiple commands correctly due to logic errors in the loop.
3. Broken Path: gencert.sh referenced incorrect binary paths, preventing certificate generation.

Fix:

1. Quoting: Added quotes around $username and $password and used read -r to prevent backslash interpretation.
2. Safe Command Execution: Refactored VPNCMD loops to use set -f (noglob) to safely execute dynamic commands without wildcard expansion, while allowing argument splitting.
3. Path Correction: Updated binary paths in gencert.sh to /usr/local/bin/.

Verification:

• Added tests/test_password_logic.sh to verify password integrity with special characters.
• Added tests/test_vpncmd_loop.sh to verify multiple commands execution.
• Manual syntax check via bash -n.

---

PR created automatically by Jules for task 8002437946464667488 started by @bluPhy

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[coderabbitai]

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}