pcsc: Allow a transaction to own the underlying card.#27
Open
nwalfield wants to merge 1 commit intobluetech:masterfrom
Open
pcsc: Allow a transaction to own the underlying card.#27nwalfield wants to merge 1 commit intobluetech:masterfrom
nwalfield wants to merge 1 commit intobluetech:masterfrom
Conversation
- Since Rust's support for self-referencial data structures is weak,
there are cases where it is useful for a transaction to own the card
and not just for it to hold a mutable reference. In these cases,
the caller needs to explicitly end the transaction to recover the
underlying card, but that is acceptable.
- Generalize `Transaction` to be generic over a `BorrowMut<Card>`.
Add new functions `Card::begin_transaction_owned` and
`Card::begin_transaction2_owned` to create this type of transaction.
Change `Transaction::end` to return the underlying card. And, add a
variant, `Transaction::end2`, to unconditionally return the
underlying card independent of whether ending the transaction
succeeded.
- Fixes bluetech#28.
nwalfield
force-pushed
the
transaction-owns-card
branch
from
351044a to
747c405
Compare
Owner
|
I left a comment regarding this PR here: #28 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Rust's support for self-referencial data structures is weak,
there are cases where it is useful for a transaction to own the card
and not just for it to hold a mutable reference. In these cases,
the caller needs to explicitly end the transaction to recover the
underlying card, but that is acceptable.
Generalize
Transactionto be generic over aBorrowMut<Card>.Add new functions
Card::begin_transaction_ownedandCard::begin_transaction2_ownedto create this type of transaction.Change
Transaction::endto return the underlying card. And, add avariant,
Transaction::end2, to unconditionally return theunderlying card independent of whether ending the transaction
succeeded.