Merged
Conversation
- Move prompts/ and agents/ files to skill root (both builders) - Rename templates/ to assets/ (both builders) - Rename resources/ to references/ to match agentskills.io spec - Remove unused tests/fixtures directories and skip guards - Update all path references across SKILL.md, build-process, quality-optimizer, quality scanners, reference docs, templates, and Python scripts - Add clear "what goes where" guidance table for root vs references vs assets vs scripts - Builders now produce output skills following the same conventions Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Move prompts/ and agents/ files to skill root in all three samples - Rename resources/ to references/ - Update all internal path references Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ructure Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…oduce a final html report
- Remove {skill-root} convention check from scanners and all reference docs
- Fix f-string lint errors (F541) in manifest.py and prepass-workflow-integrity.py
- Update stale pip install message to reference uv run with PEP 723
- Add {communication_language} config header to quality-optimizer.md
- Batch sequential file reads into parallel operations in all 6 scanner process sections
- Prior uncommitted improvements: HTML report generation, scan schema updates, scanner prompt refinements
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
This pull request is too large for Augment to review. The PR exceeds the maximum size limit of 100000 tokens (approximately 400000 characters) for automated code review. Please consider breaking this PR into smaller, more focused changes. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (106)
WalkthroughThis pull request systematically refactors file organization and standardization across multiple BMAD skills: moving prompt files from subdirectories to root level, replacing Changes
Sequence Diagram(s)sequenceDiagram
participant Scanner as LLM Scanners
participant TempFiles as Temp JSON Files
participant Normalizer as generate-html-report.py
participant Template as quality-report-template.md
participant HTML as Interactive HTML
Scanner->>TempFiles: Write findings (diverse schemas)
Normalizer->>TempFiles: Load *-temp.json & *-prepass.json
Normalizer->>Normalizer: Normalize findings to universal schema
Normalizer->>Normalizer: Compute quality grade from severities
Normalizer->>Normalizer: Extract user journeys & assessments
Normalizer->>Template: Populate template with normalized data
Template->>HTML: Render with severity filters & interactive UI
HTML->>HTML: Client-side filtering, selection, batch prompts
sequenceDiagram
participant Skill as Skill Directory
participant Scripts as Prepass/Scanner Scripts
participant Findings as Findings Array
participant Assessment as Assessments Object
participant Output as JSON Output
Skill->>Scripts: Scan root .md files (no prompts/ subdirectory)
Skill->>Scripts: Scan references/ (no resources/)
Scripts->>Scripts: Run linters (ruff, shellcheck, biome)
Scripts->>Findings: Normalize to [file, line, severity, category, title, detail, action]
Scripts->>Assessment: Collect cohesion, prompt_health, lint_summary, user_journeys
Findings->>Output: Write findings array
Assessment->>Output: Write assessments object
Output->>Output: Include summary with total_findings, by_severity, assessment
Estimated code review effort🎯 4 (Complex) | ⏱️ ~75 minutes Poem
✨ Finishing Touches
🧪 Generate unit tests (beta)
|
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Refactor
Removed Features
Chores