Skip to content

fix: coerce model to str() — prevent crash on non-string model kwargs #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmdhodl merged 2 commits into from
Mar 15, 2026
Merged

fix: coerce model to str() — prevent crash on non-string model kwargs #256

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8046d9a
fix: coerce model to str() before storing in span data
bmdhodl Mar 15, 2026
131f6b6
Merge branch 'main' into fix/sdk-model-str-coerce
bmdhodl Mar 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions sdk/agentguard/instrument.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ def _traced_openai_create(
original: Any, tracer: Any, budget_guard: Any, *args: Any, **kwargs: Any
) -> Any:
"""Shared traced wrapper for sync OpenAI create calls."""
model = kwargs.get("model", "unknown")
model = str(kwargs.get("model", "unknown"))
with tracer.trace(f"llm.openai.{model}", data={"model": model, "provider": "openai"}) as ctx:
result = original(*args, **kwargs)
_emit_llm_result(ctx, budget_guard, model, "openai", getattr(result, "usage", None))
Expand Down Expand Up @@ -294,7 +294,7 @@ def _patch_anthropic_instance(client: Any, tracer: Any, budget_guard: Any = None

@functools.wraps(original_create)
def traced_create(*args: Any, **kwargs: Any) -> Any:
model = kwargs.get("model", "unknown")
model = str(kwargs.get("model", "unknown"))
with tracer.trace(f"llm.anthropic.{model}", data={"model": model, "provider": "anthropic"}) as ctx:
result = original_create(*args, **kwargs)
_emit_llm_result(ctx, budget_guard, model, "anthropic", getattr(result, "usage", None))
Expand Down Expand Up @@ -435,7 +435,7 @@ def _patch_openai_async_instance(client: Any, tracer: Any, budget_guard: Any = N

@functools.wraps(original_create)
async def traced_create(*args: Any, **kwargs: Any) -> Any:
model = kwargs.get("model", "unknown")
model = str(kwargs.get("model", "unknown"))
async with tracer.trace(f"llm.openai.{model}", data={"model": model, "provider": "openai"}) as ctx:
result = await original_create(*args, **kwargs)
_emit_llm_result(ctx, budget_guard, model, "openai", getattr(result, "usage", None))
Expand Down Expand Up @@ -493,7 +493,7 @@ def _patch_anthropic_async_instance(client: Any, tracer: Any, budget_guard: Any

@functools.wraps(original_create)
async def traced_create(*args: Any, **kwargs: Any) -> Any:
model = kwargs.get("model", "unknown")
model = str(kwargs.get("model", "unknown"))
async with tracer.trace(f"llm.anthropic.{model}", data={"model": model, "provider": "anthropic"}) as ctx:
result = await original_create(*args, **kwargs)
_emit_llm_result(ctx, budget_guard, model, "anthropic", getattr(result, "usage", None))
Expand Down