Open
Conversation
SurajBDeore
force-pushed
the
fix-requirement-for-lobster-report
branch
from
2ff401c to
b3eaf91
Compare
phiwuu
requested changes
Sep 3, 2025
Comment on lines
+199
to
+202
| IF an item contains a "message", | ||
| THEN the item shall be counted as "not okay", | ||
| regardless of whether it traces to another item or not. | ||
| ELSE the item shall be evaluated according to the general tracing policy. |
Member
There was a problem hiding this comment.
This needs further investigation.
- It seems there is a bug, see test pr for lobster-report #460
- We need to decide about precedence: If an item has got a "message" AND a "justification", what is the expected item status?
Member
There was a problem hiding this comment.
Conclusion: "message" takes precedence over "justification". If both are given, then the above requirement still applies. But if a justification is given, then most of the tools append a "message" saying that the item does not need to be traced. And then suddenly this requirement would apply, and the item would be counted as "not okay".
phiwuu
added
the
bug
phiwuu
approved these changes
Sep 9, 2025
phiwuu
force-pushed
the
fix-requirement-for-lobster-report
branch
from
b3eaf91 to
d689db5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.