Maxutil: BlitzMaxPath scans CurrentDir for BMK too#5
Open
GWRon wants to merge 1 commit intobmx-ng:masterfrom
Open
Maxutil: BlitzMaxPath scans CurrentDir for BMK too#5GWRon wants to merge 1 commit intobmx-ng:masterfrom
GWRon wants to merge 1 commit intobmx-ng:masterfrom
Conversation
- changed BlitzMaxPath() to scan AppDir and CurrentDir, this allows BMK to be a symlinked binary - kept "path + bin/bmk" to avoid registering the CurrentDir() as BlitzMax path just because it contains a "bmk[.exe]" file. Maybe it is better to check for more than just "this file" to accept it as "BlitzMax"-Path)
Contributor
Author
|
Thoughts? Decline? Accept? |
Contributor
Author
|
Slightly related to: |
Contributor
Author
|
Is there as reason speaking against this change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@woollybah
Feel free to NOT accept this pull request - it is not needed for everyone (but you know, cleaner working directories might help during development). If you want to have the ability to run "bmk makemods" from your individual directory, while the environment variable is set to another BlitzMax-directory then we should change order of checks to this:
So we could run it from our individual directory without modifying system wide variables or other things.