Conversation
Owner
|
Thanks for taking a first cut at this! Spinning it up locally, I see elements that are unbounded & behave a bit weird like the following: Are you looking for feedback yet, or still iterating? A couple leads I'd suggest looking at are using the |
Collaborator
Author
|
Yes, I'm happy for any and all feedback. I assumed there would be some
simple things that I had overlooked. :) I will definitely look into the
container class and implementing a card component. Let me know what you've
called the sponsorship page data on Prismic and I can incorporate that as
well.
Thanks!
…On Sun, Sep 25, 2022 at 10:54 PM Brendon Earl ***@***.***> wrote:
Thanks for taking a first cut at this!
Spinning it up locally, I see elements that are unbounded & behave a bit
weird like the following:
[image: Screen Shot 2022-09-25 at 10 47 54 PM]
<https://user-images.githubusercontent.com/11308382/192202627-256414b8-2719-4811-9cdc-f7da407f1988.png>
[image: Screen Shot 2022-09-25 at 10 49 48 PM]
<https://user-images.githubusercontent.com/11308382/192202609-97025e51-5857-4629-bdb9-5d6ef152f048.png>
Are you looking for feedback yet, or still iterating?
A couple leads I'd suggest looking at are using the container css class
that's available to all components (see in _base.scss). And maybe
creating a "card" component to wrap up the contents for a sponsor like
the following
<https://picturepan2.github.io/spectre/components/cards.html> (we have
spectre <https://picturepan2.github.io/spectre/index.html> imported and
available for use in the repo already :) )
[image: Screen Shot 2022-09-25 at 10 52 22 PM]
<https://user-images.githubusercontent.com/11308382/192202989-e784ea5a-3afa-43f8-b345-6c08d8376785.png>
—
Reply to this email directly, view it on GitHub
<#44 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASIT4NO4FMLVWKGHQB3JRRTWAE3B3ANCNFSM6AAAAAAQVLQYCU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Owner
|
Alrightly, got the page setup in prismic :) The query feels a little funny because it doesn't use the Query: query MyQuery {
prismicSponsorshipPage {
data {
body {
id
items {
card_description {
text
type
}
card_title {
text
type
}
cta_link {
link_type
}
cta_text {
type
text
}
}
primary {
anchor
tier
sponsors_card_list_title {
text
type
}
text {
text
type
}
}
slice_type
}
subtitle {
type
text
}
title {
text
type
}
}
}
}
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




First draft of the sponsorship page. Currently using dummy data combined with sponsor data pulled from prismic.