Feature/plugin/shaders #49
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| struct ShaderModuleDesc | ||
| { | ||
| // ShaderSourceType type; |
Check notice
Code scanning / CodeQL
Commented-out code Note
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 16 days ago
To fix the problem, simply remove the commented-out code on line 36: // ShaderSourceType type;. This will make the code cleaner, less confusing, and prevent the risk of misleading developers or creating unnecessary clutter. Only edit the affected region, leaving the remainder of the struct and file unchanged. No further changes, imports, methods, or definitions are necessary.
Suggested changeset
1
modules/Interfaces/include/Interfaces/Renderer/IShader.hpp
| @@ -33,7 +33,6 @@ | ||
|
|
||
| struct ShaderModuleDesc | ||
| { | ||
| // ShaderSourceType type; | ||
| ShaderID id; | ||
| std::string source; | ||
| ShaderStage stage; |
Copilot is powered by AI and may make mistakes. Always verify output.
from application/engine to renderer plugin without hard coded shaders in renderer
bobis33
force-pushed
the
Feature/Plugin/Shaders
branch
2 times, most recently
from
0b8417c to
88dc66b
Compare
bobis33
force-pushed
the
Feature/Plugin/Shaders
branch
from
88dc66b to
fa43b80
Compare
bobis33
force-pushed
the
Feature/Plugin/Shaders
branch
from
7cf894b to
d57fa27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.