security: Updating AES mode to one that does not require a unique IV#7
Open
ZephSibley wants to merge 1 commit intobobricius:mainfrom
Open
security: Updating AES mode to one that does not require a unique IV#7ZephSibley wants to merge 1 commit intobobricius:mainfrom
ZephSibley wants to merge 1 commit intobobricius:mainfrom
Conversation
|
Also see https://github.com/rgrizzell/Armachat-circuitpython/blob/refactor/docs/guides/user_guide.md, there was some work done on a refactor but unclear where it stands at this moment |
Owner
|
There is many non working thinks. etc addressing and communication, I was not able run this refactor fork |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looking at the config around the IV and the use of it in the code it seems that the system would encrypt more than one message with the same IV, making the messages vulnerable to attacks explained here
This PR changes the mode to CBC, which can use a fixed IV, and has minimal drawbacks. An alternative to this would be to use a nonce as the IV and send it along with the ciphertext for use in decryption.
Thanks!