Open
Conversation
milofultz
requested changes
Sep 24, 2021
Contributor
milofultz
left a comment
milofultz
left a comment
There was a problem hiding this comment.
Helmet question re: rendering component within
| <Helmet> | ||
| <script | ||
| src="https://www.paypal.com/sdk/js?client-id=AcuzwYns3SuSSdJfwStMFCPsnRV3Ohu3ebkRskSvHlnR0p3UXVuhIcMbdUXpsBY6ISfepv7yQ2YQtpCC" /> | ||
| <PayBill finalTotals={finalTotals} hostInfo={hostInfo} /> |
Contributor
There was a problem hiding this comment.
I think this injects your PayBill component into the head of the page? Not super familiar with helmet, but I don't know if this is correct
Contributor
Author
There was a problem hiding this comment.
Well, I think you are right, the paybill should be out of the helmet, now the Paybill's test coverage is just 6% which means most are not rendered yet....I'll look into this.
| <script | ||
| src="https://www.paypal.com/sdk/js?client-id=AcuzwYns3SuSSdJfwStMFCPsnRV3Ohu3ebkRskSvHlnR0p3UXVuhIcMbdUXpsBY6ISfepv7yQ2YQtpCC" /> | ||
| <PayBill finalTotals={finalTotals} hostInfo={hostInfo} /> | ||
| </Helmet>); |
Contributor
There was a problem hiding this comment.
Rogue parentheses before the end of the render block
jabrake
approved these changes
Sep 24, 2021
Collaborator
jabrake
left a comment
jabrake
left a comment
There was a problem hiding this comment.
Looks good to me, just echoing Milo's comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.