M3MS-224 - Additional logging of exceptions for possible monitoring a…#2
Open
baptista007 wants to merge 3 commits intoboesemar:masterfrom
Open
M3MS-224 - Additional logging of exceptions for possible monitoring a…#2baptista007 wants to merge 3 commits intoboesemar:masterfrom
baptista007 wants to merge 3 commits intoboesemar:masterfrom
Conversation
…dded. Controlled by boolean flag exceptions_log in m3ms config file
boesemar
requested changes
Jan 18, 2022
lib/cuca/app.rb
Outdated
Owner
There was a problem hiding this comment.
I'd prefer to pass the logger object directly with App.config['excepsion_log'], then it can also be configured as a user likes.
Example:
@exception_logger = Logger.new('/dev/null')
if App.config['exception_log'] then
raise CucaException, "exception_log needs to be kind of Logger" unless App.config['excepion_log'].kind_of?(Logger)
@exception_logger = App.config['exception_log']
end
Author
There was a problem hiding this comment.
Very good suggestion. Implemented with commit 61d9c10
…defined app. Object passed to cuca
boesemar
approved these changes
Jun 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…dded. Controlled by boolean flag exceptions_log in m3ms config file