Skip to content

M3MS-224 - Additional logging of exceptions for possible monitoring a…#2

Open
baptista007 wants to merge 3 commits intoboesemar:masterfrom
baptista007:master
Open

M3MS-224 - Additional logging of exceptions for possible monitoring a…#2
baptista007 wants to merge 3 commits intoboesemar:masterfrom
baptista007:master

Conversation

@baptista007
Copy link

…dded. Controlled by boolean flag exceptions_log in m3ms config file

Baptista Joao and others added 2 commits September 9, 2021 09:42
lib/cuca/app.rb Outdated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to pass the logger object directly with App.config['excepsion_log'], then it can also be configured as a user likes.
Example:
@exception_logger = Logger.new('/dev/null')

if App.config['exception_log'] then
raise CucaException, "exception_log needs to be kind of Logger" unless App.config['excepion_log'].kind_of?(Logger)
@exception_logger = App.config['exception_log']
end

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good suggestion. Implemented with commit 61d9c10

@baptista007 baptista007 requested a review from boesemar May 18, 2022 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments