Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces the
busy_threadsmetric to the Puma Cloudwatch integration, updates the metric parsing and sending logic, and adjusts the corresponding tests to accommodate the new metric.Metrics Addition:
busy_threadsto the list of metrics inlib/puma_cloudwatch/metrics/parser.rb.callmethod documentation to includebusy_threadsinlib/puma_cloudwatch/metrics/parser.rbandlib/puma_cloudwatch/metrics/sender.rb. [1] [2]Documentation Update:
busy_threadsmetric in theREADME.mdfile.Test Adjustments:
spec/puma_cloudwatch/metrics/fetcher_spec.rbto use a mock socket and updated the test description.spec/puma_cloudwatch/metrics/parser_spec.rbto includebusy_threadsin the test data and expectations. [1] [2] [3] [4] [5]spec/puma_cloudwatch/metrics/sender_spec.rbto validate the inclusion ofbusy_threadsin the metric data and its storage resolution. [1] [2] [3] [4]