Skip to content

Comments

Add busy_threads statistic#21

Open
rnhurt wants to merge 4 commits intoboltops-tools:masterfrom
rnhurt:fix/add-busy_threads
Open

Add busy_threads statistic#21
rnhurt wants to merge 4 commits intoboltops-tools:masterfrom
rnhurt:fix/add-busy_threads

Conversation

@rnhurt
Copy link

@rnhurt rnhurt commented Apr 10, 2025

This pull request introduces the busy_threads metric to the Puma Cloudwatch integration, updates the metric parsing and sending logic, and adjusts the corresponding tests to accommodate the new metric.

Metrics Addition:

  • Added busy_threads to the list of metrics in lib/puma_cloudwatch/metrics/parser.rb.
  • Updated the example structure in the call method documentation to include busy_threads in lib/puma_cloudwatch/metrics/parser.rb and lib/puma_cloudwatch/metrics/sender.rb. [1] [2]

Documentation Update:

  • Added a description for the busy_threads metric in the README.md file.

Test Adjustments:

  • Modified spec/puma_cloudwatch/metrics/fetcher_spec.rb to use a mock socket and updated the test description.
  • Updated spec/puma_cloudwatch/metrics/parser_spec.rb to include busy_threads in the test data and expectations. [1] [2] [3] [4] [5]
  • Adjusted spec/puma_cloudwatch/metrics/sender_spec.rb to validate the inclusion of busy_threads in the metric data and its storage resolution. [1] [2] [3] [4]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant