chore(ci): add Node.js v20 to CI #204
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds Node.js v20 support to the CI pipeline. Since Node.js v20's native node --test command doesn't support glob patterns, a custom test runner script is introduced to work around this limitation.
Key Changes:
- Created a custom test runner script that uses the
globpackage to find test files and pass them to Node.js v20's test runner - Enabled Node.js v20 in the GitHub Actions test matrix with conditional execution logic
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| scripts/run-tests-v20.js | New test runner script that resolves glob patterns for Node.js v20's test command |
| .github/workflows/nodejs.yml | Uncommented Node.js v20 from the test matrix and added conditional test steps to use the custom runner for v20 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| import { globSync } from 'glob'; | ||
| /** | ||
| * Test runner for Node.js v20 | ||
| * | ||
| * Node.js v20's `node --test` command doesn't support glob patterns. This | ||
| * script uses the `glob` package to find test files and passes them to `node | ||
| * --test`. | ||
| */ | ||
| import { execFileSync } from 'node:child_process'; |
There was a problem hiding this comment.
Import statements are not in the correct order. By convention, Node.js built-in module imports (prefixed with 'node:') should come before external package imports. The import from 'node:child_process' on line 10 should be placed before the import from 'glob' on line 2. Additionally, the JSDoc comment should be placed after all imports rather than between them.
No description provided.