Ateeb Salam #94
Open
Ateeb Salam #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amos1969
reviewed
Jan 19, 2024
| ArrayList<String> bagels; | ||
| int capacity = 2; | ||
| public Basket(){ | ||
| this.bagels = new ArrayList<>(capacity); |
Contributor
There was a problem hiding this comment.
As I said in this morning's session it's best not to hard code example data into your code, do it in the tests instead.
amos1969
reviewed
Jan 19, 2024
| int updateCap=10; | ||
| String returnV = basket.removeBagelString("bagel10"); | ||
| Assertions.assertEquals("The bagel " + "bagel10" + " doesn't exist",returnV); | ||
| } |
Contributor
There was a problem hiding this comment.
This test appears to start off with the intention of updating the capacity but then ends up with code that tries to remove an non-existent bagel from the basket.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.