Conversation
juanjoman
approved these changes
May 13, 2021
Contributor
juanjoman
left a comment
juanjoman
left a comment
There was a problem hiding this comment.
LGTM! We should also update these versions for all rockets when possible
adriangmweb
force-pushed
the
fix/node16-bug
branch
from
1095fc3 to
84d8c51
Compare
alvaroloes
reviewed
May 14, 2021
Contributor
alvaroloes
left a comment
alvaroloes
left a comment
There was a problem hiding this comment.
Just remember to check the unit tests (they are failing) and integration tests
Contributor
Author
Working on it 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There is an issue when deploying on node v16 or later where CloudFormation fails because the Lambda zip files are empty. After some investigation seems that there is an issue with the
aws-cdkversion that we were using.Also, we were using the
rmDirfunction from the nodefspackage which has been deprecated on node v16.Closes #823
Changes
aws-cdkandaws-sdkversions to the latest stable, compatible and reliable without breaking changes versions that fix that error.rm({recursive: true})instead of the deprecatedrmDirfunction form the nodefspackage.v14.14Checks
Additional information
These changes have been tested on node v14, node v15, and node v16.