Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #315 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 23 23
Branches 10 10
=========================================
Hits 23 23 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Flamefire
force-pushed
the
fix-symlink-usage
branch
from
6f203c8 to
636798e
Compare
Flamefire
force-pushed
the
fix-symlink-usage
branch
from
09adf46 to
a23edc5
Compare
Flamefire
force-pushed
the
fix-symlink-usage
branch
5 times, most recently
from
df902b0 to
a62d6b3
Compare
Test that handling symlinks on CI works. See #314
Copying a relative symlink may fail if it is copied before its target, e.g. `src/symlink.test -> test/test2.hpp` (`src` is ordered before `test`): > cannot create symbolic link 'libs/boost-ci/src/symlink.test': No such file or directory Cygwin allows relaxing the security checks against the link target, see https://df.tips/t/topic/2628
Flamefire
force-pushed
the
fix-symlink-usage
branch
from
fb5bec1 to
e8cd677
Compare
Flamefire
force-pushed
the
fix-symlink-usage
branch
from
e8cd677 to
facaad5
Compare
"Redirecting" the copy through tar avoids creating symlinks to (yet) non-existing files. Fixes #314
Flamefire
force-pushed
the
fix-symlink-usage
branch
from
facaad5 to
47fa565
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test that handling symlinks on CI works.
Then fix the scripts as necessary.
Fixes #314