Skip to content

Fix types for compatibility with int128 #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mborland merged 1 commit into from
Jan 28, 2026
Merged

Fix types for compatibility with int128 #288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/boost/charconv/detail/integer_search_trees.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ BOOST_CHARCONV_CXX14_CONSTEXPR int num_digits(T x) noexcept

while (x)
{
x /= 10;
x /= static_cast<T>(10);
++digits;
}

Expand Down
20 changes: 10 additions & 10 deletions include/boost/charconv/detail/to_chars_integer_impl.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ BOOST_CHARCONV_CONSTEXPR to_chars_result to_chars_128integer_impl(char* first, c
#endif
)
{
if (value < 0)
if (value < static_cast<Integer>(0))
{
is_negative = true;
unsigned_value = -(static_cast<Unsigned_Integer>(value));
Expand Down Expand Up @@ -278,7 +278,7 @@ BOOST_CHARCONV_CONSTEXPR to_chars_result to_chars_128integer_impl(char* first, c
int num_chars[5] {};
int i = 0;

while (converted_value != 0)
while (converted_value != static_cast<Unsigned_Integer>(0))
{
auto digits = static_cast<std::uint32_t>(converted_value % ten_9);
num_chars[i] = num_digits(digits);
Expand Down Expand Up @@ -320,7 +320,7 @@ BOOST_CHARCONV_CONSTEXPR to_chars_result to_chars_integer_impl(char* first, char
return {last, std::errc::invalid_argument};
}

if (value == 0)
if (value == static_cast<Integer>(0))
{
*first++ = '0';
return {first, std::errc()};
Expand All @@ -331,7 +331,7 @@ BOOST_CHARCONV_CONSTEXPR to_chars_result to_chars_integer_impl(char* first, char

BOOST_IF_CONSTEXPR (std::is_signed<Integer>::value)
{
if (value < 0)
if (value < static_cast<Integer>(0))
{
*first++ = '-';
unsigned_value = static_cast<Unsigned_Integer>(detail::apply_sign(value));
Expand All @@ -358,47 +358,47 @@ BOOST_CHARCONV_CONSTEXPR to_chars_result to_chars_integer_impl(char* first, char
switch (base)
{
case 2:
while (unsigned_value != 0)
while (unsigned_value != static_cast<Unsigned_Integer>(0))
{
*end-- = static_cast<char>(zero + (unsigned_value & 1U)); // 1<<1 - 1
unsigned_value >>= static_cast<Unsigned_Integer>(1);
}
break;

case 4:
while (unsigned_value != 0)
while (unsigned_value != static_cast<Unsigned_Integer>(0))
{
*end-- = static_cast<char>(zero + (unsigned_value & 3U)); // 1<<2 - 1
unsigned_value >>= static_cast<Unsigned_Integer>(2);
}
break;

case 8:
while (unsigned_value != 0)
while (unsigned_value != static_cast<Unsigned_Integer>(0))
{
*end-- = static_cast<char>(zero + (unsigned_value & 7U)); // 1<<3 - 1
unsigned_value >>= static_cast<Unsigned_Integer>(3);
}
break;

case 16:
while (unsigned_value != 0)
while (unsigned_value != static_cast<Unsigned_Integer>(0))
{
*end-- = digit_table[static_cast<std::size_t>(unsigned_value & 15U)]; // 1<<4 - 1
unsigned_value >>= static_cast<Unsigned_Integer>(4);
}
break;

case 32:
while (unsigned_value != 0)
while (unsigned_value != static_cast<Unsigned_Integer>(0))
{
*end-- = digit_table[static_cast<std::size_t>(unsigned_value & 31U)]; // 1<<5 - 1
unsigned_value >>= static_cast<Unsigned_Integer>(5);
}
break;

default:
while (unsigned_value != 0)
while (unsigned_value != static_cast<Unsigned_Integer>(0))
{
*end-- = digit_table[static_cast<std::size_t>(unsigned_value % unsigned_base)];
unsigned_value /= unsigned_base;
Expand Down