Skip to content

Avoid ODR violations by using fixed types for protocol constants #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
klemens-morgenstern merged 1 commit into from
Oct 6, 2025
Merged

Avoid ODR violations by using fixed types for protocol constants #244

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions include/boost/cobalt/io/endpoint.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,9 @@ struct stream_socket;

struct protocol_type
{
using family_t = decltype(BOOST_ASIO_OS_DEF(AF_INET));
using type_t = decltype(BOOST_ASIO_OS_DEF(SOCK_STREAM));
using protocol_t = decltype(BOOST_ASIO_OS_DEF(IPPROTO_TCP));
using family_t = int;
using type_t = int;
using protocol_t = int;

constexpr family_t family() const noexcept {return family_;};
constexpr type_t type() const noexcept {return type_;};
Expand Down Expand Up @@ -90,9 +90,9 @@ struct protocol_type
protocol_t protocol_ = static_cast<protocol_t>(0);
};

template<auto Family = static_cast<protocol_type::family_t>(0),
auto Type = static_cast<protocol_type::type_t>(0),
auto Protocol = static_cast<protocol_type::protocol_t>(0)>
template<protocol_type::family_t Family = static_cast<protocol_type::family_t>(0),
protocol_type::type_t Type = static_cast<protocol_type::type_t>(0),
protocol_type::protocol_t Protocol = static_cast<protocol_type::protocol_t>(0)>
struct static_protocol
{
using family_t = protocol_type::family_t ;
Expand Down
Loading