Qualify calls to placement new #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Callables are sufficiently small, they're emplaced into a small
buffer directly by placement new. If one, however, uses an unqualified
call to placement new, the class-based overloads are picked up and
compilation fails.
libs/compat/test/move_only_function_test.cpp:107:11: note: candidate
function not viable: requires 1 argument, but 2 were provided
107 | void* operator new(std::size_t) { throw 1234; }
To avoid class-based overload sets for operator new, we qualify our calls to placement new with `::new` which forces us to pick up the correct overload when emplacing objects in the small buffer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a compilation failure when SBO-friendly Callables provide their own overloads for operator new.