queue: allow non-trivially moveable types#118
Merged
timblechmann merged 1 commit intoboostorg:developfrom May 19, 2025
Merged
Conversation
Restores the requirements prior to commit 6a70a65 which replaced boost::has_trivial_assign with std::is_trivially_assignable. The latter trait requires both trivial copy and move assignment while the original only required trivial copy assignment. Since the lockfree queue doesn't require trivial move assignment, the requirement is being reverted back to the original. Also updated the documentation to clarify only trivial copy assignment is needed. Fixes boostorg#117
Collaborator
|
@praetorian20, many thanks for the patch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores the requirements prior to commit 6a70a65 which replaced boost::has_trivial_assign with std::is_trivially_assignable.
The latter trait requires both trivial copy and move assignment while the original only required trivial copy assignment. Since the lockfree queue doesn't require trivial move assignment, the requirement is being reverted back to the original.
Also updated the documentation to clarify only trivial copy assignment is needed.
Fixes #117