minimal changes to allow single move only values to be pushed and poped (version 2)#41
Open
tnovotny wants to merge 10 commits intoboostorg:developfrom
Open
minimal changes to allow single move only values to be pushed and poped (version 2)#41tnovotny wants to merge 10 commits intoboostorg:developfrom
tnovotny wants to merge 10 commits intoboostorg:developfrom
Conversation
use BOOST_NO_CXX11_RVALUE_REFERENCES to hide functions that take rvalue references add detail::is_move_assignable as the boost type_traits don't seem to have one switch from std::enable_if to boost::enable_if and disable_if switch from std::move to boost::move
tnovotny
changed the title
#include type_traits only if we need it
the SFINAE had to be rewritten in a C++98 compatible way it now compiles when I use set(CMAKE_CXX_STANDARD 98)
the receiver was originally a convertible template paramter. this erroneously got changed while trying to get it to compile.
Author
|
@timblechmann feedback? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have made the requested changes. I have not managed to verify that this actually will compile with a C++03/C++98 compiler.