Build examples in CMake#103
Conversation
This makes the option visible in the cmake user front-end.
BOOST_NUMERIC_ODEINT_ADAPTORS only turns off two dependencies at this time: boost::compute and boost::mpi. Factor out the unconditional dependencies to make this clearer in the CMake script.
This prevents us from accidentally using the wrong indent level in the editor, etc.
Implementation follows the existing jam files, so the following subdirectories in examples are skipped: - mtl - ublas - gmpxx - openmp - mpi
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #103 +/- ##
===========================================
- Coverage 99.43% 99.40% -0.03%
===========================================
Files 168 168
Lines 7556 7556
===========================================
- Hits 7513 7511 -2
- Misses 43 45 +2 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
I think this can be made much simpler. We already have The examples could be added to run in the test/ Jamfile (as they are in many libraries) and then |
|
That sounds fine to me, feel free to discard this if there is some other magical way of making it happen in bjam and CMake. Boost.build is nebulous to me, although I understand CMake pretty well. |
|
Should we close this PR then? |
2 participants
This adds CMake build script support for building the examples that are currently built with bjam.
This should help in preventing build-rot from creeping into the example programs.
I ran all the examples manually to verify that they didn't assert or crash.
I'm open to discussion on the changes made to the top-level CMakeLists.txt to find Boost dependencies;
this was necessary for me to build the examples by checking out this repository alone.
Please let me know if you prefer to have everything squished to a single commit; that's not a problem for me.