Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the AdaptSize cache library from a full key-value store to a policy-only admission controller. The cache no longer stores actual values or manages LRU eviction—instead, callers integrate it with their own storage layer and use the Request API to record accesses and get admission decisions for cache misses. The core AdaptSize algorithm (probabilistic admission via exp(-size/c) with automatic c-parameter tuning) remains unchanged.
Key Changes:
- Replaced
Get/Setmethods with a singleRequestmethod that records metrics and returns admission decisions - Removed internal storage structures (
itemsmap,lrulist,entrytype) and capacity tracking - Updated all tests to use the new API pattern where callers specify
Hitstatus
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| go.mod | Updates Go version (contains invalid version number) |
| adaptsize/adaptsize.go | Removes value storage and LRU eviction; adds Request API for admission decisions only |
| adaptsize/adaptsize_test.go | Updates existing tests to Request API; adds new tests for hit recording, oversize handling, EMA computation, and no-data tuning behavior |
| README.md | Updates usage example to demonstrate Request API pattern with caller-managed cache storage |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.