Migrate screens and sort button to 1.21.10 input API (KeyInput/Click) #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace deprecated key/mouse handlers with KeyInput/Click - Update SortButton to extend PressableWidget and use onPress(AbstractInput) - Adjust mixins for Inventory/Container/Shulker screens to new signatures - Keep button positioning logic the same
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the mod to run on Minecraft/Fabric 1.21.10 (Yarn 1.21.10+build.2).
Mojang/Fabric changed the client input API in this version (key/mouse events now use
KeyInput,Click, andAbstractInput), so the GUI mixins and the custom SortButtonneeded to be adjusted.
What changed
SortButtonto extendPressableWidgetand to overrideonPress(AbstractInput)instead of the removedonClick(...)method signatures:
keyPressed(KeyInput keyInput)mouseClicked(Click click, boolean doubleClick)matchesKey(int, int),matchesMouse(int))with the new ones that take the input objects
Config.*offsets)