Merged
Conversation
ec80359 to
232dc62
Compare
Contributor
Author
|
when I added testcases, description will be filled, and I will request the review. |
Contributor
Author
146b47c to
691e19e
Compare
9e1075e to
5c697ba
Compare
Contributor
Author
|
@anarcher review please ~~ |
Codecov Report
@@ Coverage Diff @@
## master #763 +/- ##
==========================================
+ Coverage 59.51% 62.28% +2.77%
==========================================
Files 148 148
Lines 9566 9642 +76
==========================================
+ Hits 5693 6006 +313
+ Misses 3248 2996 -252
- Partials 625 640 +15
Continue to review full report at Codecov.
|
5c697ba to
af02c7e
Compare
af02c7e to
9acc01c
Compare
Contributor
|
Can you rebase from #765 ? This PR is merged from #765. I think that It merged after #765 is merged. |
9acc01c to
02f9c72
Compare
Contributor
Author
6 tasks
Contributor
|
Too late, 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Github Issue
#680
Background
Current
/accounts/{id}/operationsAPI returns operations which are sent by source onlyThe client such as wallet and Explorer requires that the API returns operations which are related not only source but also the target.
Solution
Add target index for block operation
Add peers index for block operation
query operations for peers index
Possible Drawbacks