Skip to content

operation index for target also#763

Merged
kfangw merged 7 commits intobosnet:masterfrom
kfangw:680-operation-index
Nov 23, 2018
Merged

operation index for target also#763
kfangw merged 7 commits intobosnet:masterfrom
kfangw:680-operation-index

Conversation

@kfangw
Copy link
Contributor

@kfangw kfangw commented Nov 19, 2018

Github Issue

#680

Background

Current /accounts/{id}/operations API returns operations which are sent by source only
The client such as wallet and Explorer requires that the API returns operations which are related not only source but also the target.

Solution

  • Add target index for block operation

  • Add peers index for block operation

  • query operations for peers index

Possible Drawbacks

@kfangw kfangw force-pushed the 680-operation-index branch from ec80359 to 232dc62 Compare November 19, 2018 09:47
@kfangw
Copy link
Contributor Author

kfangw commented Nov 19, 2018

when I added testcases, description will be filled, and I will request the review.

@kfangw
Copy link
Contributor Author

kfangw commented Nov 20, 2018

This PR depends on #765 and #766.
Hence, this will be resumed when those are merged.

@kfangw
Copy link
Contributor Author

kfangw commented Nov 22, 2018

@anarcher review please ~~

@kfangw kfangw changed the title [WIP] operation index operation index for target also Nov 22, 2018
@codecov-io
Copy link

codecov-io commented Nov 22, 2018

Codecov Report

Merging #763 into master will increase coverage by 2.77%.
The diff coverage is 63.04%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #763      +/-   ##
==========================================
+ Coverage   59.51%   62.28%   +2.77%     
==========================================
  Files         148      148              
  Lines        9566     9642      +76     
==========================================
+ Hits         5693     6006     +313     
+ Misses       3248     2996     -252     
- Partials      625      640      +15
Flag Coverage Δ
#integration_tests_long_term 45.83% <59.78%> (?)
#integration_tests_node 41.28% <59.78%> (+0.53%) ⬆️
#unittests 51.23% <63.04%> (+0.12%) ⬆️
Impacted Files Coverage Δ
lib/transaction/operation/operation.go 43.11% <ø> (ø) ⬆️
lib/node/runner/api/operation.go 76% <100%> (ø) ⬆️
lib/node/runner/api/api.go 91.66% <100%> (ø) ⬆️
lib/node/runner/api/resource/operation.go 80.76% <100%> (+0.76%) ⬆️
lib/block/operation.go 63.31% <61.36%> (+0.98%) ⬆️
cmd/sebak/cmd/run.go 66.43% <0%> (+0.46%) ⬆️
lib/node/runner/isaac_state_manager.go 95.81% <0%> (+1.39%) ⬆️
lib/node/runner/api_block.go 67.5% <0%> (+1.66%) ⬆️
lib/common/net.go 28.84% <0%> (+1.92%) ⬆️
lib/node/runner/node_runner.go 79.85% <0%> (+1.94%) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b06e3a...83696ad. Read the comment docs.

@kfangw kfangw force-pushed the 680-operation-index branch from 5c697ba to af02c7e Compare November 22, 2018 06:54
@kfangw kfangw mentioned this pull request Nov 22, 2018
@kfangw kfangw force-pushed the 680-operation-index branch from af02c7e to 9acc01c Compare November 22, 2018 07:17
@anarcher
Copy link
Contributor

Can you rebase from #765 ? This PR is merged from #765. I think that It merged after #765 is merged.
What do you think this and that (#765) ? @kfangw @spikeekips @Charleslee522 @Geod24

@kfangw kfangw added bug Something isn't working Urgent labels Nov 23, 2018
@kfangw kfangw modified the milestones: Toward v0.1.0, MainNet Nov 23, 2018
@kfangw kfangw force-pushed the 680-operation-index branch from 9acc01c to 02f9c72 Compare November 23, 2018 08:43
@kfangw
Copy link
Contributor Author

kfangw commented Nov 23, 2018

I rebased it on master not #765
Could you review again? @anarcher

Copy link
Contributor

@anarcher anarcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kfangw kfangw merged commit e293ff8 into bosnet:master Nov 23, 2018
@kfangw kfangw deleted the 680-operation-index branch November 23, 2018 12:07
@spikeekips
Copy link
Contributor

Too late, 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Urgent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants