Merged
Conversation
ewjoachim
approved these changes
Jan 17, 2025
Contributor
ewjoachim
left a comment
ewjoachim
left a comment
There was a problem hiding this comment.
Love it. If you fix the last 2 missing spaces, I say let's merge !
Comment on lines
+46
to
+49
| - name: Install uv | ||
| uses: astral-sh/setup-uv@v5 | ||
| with: | ||
| enable-cache: true |
| PYTHON=${PYTHON:-python} | ||
| # run tests | ||
| $PYTHON -m pytest --no-success-flaky-report -q $PYTEST_OPTIONS "$@" | ||
| pytest --no-success-flaky-report -q $PYTEST_OPTIONS "$@" |
Contributor
There was a problem hiding this comment.
(for next PR: https://pypi.org/project/pytest-env/ and the PYTEST_OPTIONS should rather be in pyproject.toml, as addopts)
| - name: Test | ||
| run: | | ||
| ./script/test -v | ||
| uv run ./script/test -v |
Contributor
There was a problem hiding this comment.
Someday, we may even not need a custom script and we can launch pytest directly :D
|
|
||
| if not isinstance(value, Domain): | ||
| err = "domain property has to be of" f"swf.model.domain.Domain type, not {type(value)!r}" | ||
| err = f"domain property has to be ofswf.model.domain.Domain type, not {type(value)!r}" |
Contributor
There was a problem hiding this comment.
Oh, a good opportunity to fix that
| def domain(self, value: Domain): | ||
| if not isinstance(value, Domain): | ||
| err = "domain property has to be of" f"swf.model.domain.Domain type, not {type(value)!r}" | ||
| err = f"domain property has to be ofswf.model.domain.Domain type, not {type(value)!r}" |
Signed-off-by: Yves Bastide <yves@botify.com>
Signed-off-by: Yves Bastide <yves@botify.com>
WIP Signed-off-by: Yves Bastide <yves@botify.com>
Signed-off-by: Yves Bastide <yves@botify.com>
Signed-off-by: Yves Bastide <yves@botify.com>
Signed-off-by: Yves Bastide <yves@botify.com>
Contributor
|
(do you plan to add something else to the PR ? Is it still a draft ?) |
Signed-off-by: Yves Bastide <yves@botify.com>
Contributor
Author
Sorry, I had forgotten it 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two unrelated commits as usual 🙈
Signed-off-by: Yves Bastide yves@botify.com