added an option to use namespaced instances of socket.io directly#4
Open
oneto018 wants to merge 3 commits intobotmasterai:masterfrom
Open
added an option to use namespaced instances of socket.io directly#4oneto018 wants to merge 3 commits intobotmasterai:masterfrom
oneto018 wants to merge 3 commits intobotmasterai:masterfrom
Conversation
… customise socket.io config and allow multiplexing single socket.io instance for multiple bots
…ance of namespaced socket.io for customization
Member
|
Hi @oneto018, Thanks for the pull request. Will need to make sure to test that code before I can merge the request. When doing so, make sure that the tests pass for not only having a scoped namespace per SocketioBot instance, but also within said namespace, using "botmasterUserId" and what happens when the same botmasterUserId is used accross two different namespaces. Really answering the question what should happen in such cases. |
|
Any updates? |
|
I am sorry! I completely forgot about this. If this feature is something others interested in, I will write the tests when I have time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this merge, it would be possible to use single instance of socket.io with multiple chatbots with namespacing option from socket.io.
Basically this allows optional setting (in place of server) socket_io. Thats supposed to be an instance of socket.io or namespaced instance
https://socket.io/docs/rooms-and-namespaces/#custom-namespaces