a few language corrections for https://bottosson.github.io/posts/colorpicker/#5
Open
GerHobbelt wants to merge 1 commit intobottosson:masterfrom
Open
a few language corrections for https://bottosson.github.io/posts/colorpicker/#5GerHobbelt wants to merge 1 commit intobottosson:masterfrom
GerHobbelt wants to merge 1 commit intobottosson:masterfrom
Conversation
…, here's the actual changes: "is a about" --> "is about" "would would" --> "what would" "best possible an appearance modelling color space" --> "best possible appearance a modelling color space" "of slices Okhsl" --> "of slices in Okhsl" (alt: "of slices of Okhsl" but for me 'in' reads better than the more technical correct 'of') "variation is absolute brightness" --> "variation in absolute brightness" "but with and added" --> "but with an added"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the page render is bloody hard to diff sensibly, here's the actual changes:
"is a about" --> "is about"
"would would" --> "what would"
"best possible an appearance modelling color space" --> "best possible appearance a modelling color space"
"of slices Okhsl" --> "of slices in Okhsl" (alt: "of slices of Okhsl" but for me 'in' reads better than the more technical correct 'of')
"variation is absolute brightness" --> "variation in absolute brightness"
"but with and added" --> "but with an added"
(I wrote the git commit message as I went, so it says "two English typos.." because that's when I decided to send an edit => pullreq.)
Thanks for coming up with OKlab and writing these blog articles. Much appreciated!