Suggesting wording to clarify tht okL<sub>R</sub>CH is not the same as okLCH#8
Open
intervexual wants to merge 1 commit intobottosson:masterfrom
Open
Suggesting wording to clarify tht okL<sub>R</sub>CH is not the same as okLCH#8intervexual wants to merge 1 commit intobottosson:masterfrom
intervexual wants to merge 1 commit intobottosson:masterfrom
Conversation
Editing confusing description: it's not actually comparing to okLCH it's comparing to a variant of okLCH.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I'm suggesting a small change to the language at the top of the page. The current language says (and certainly gave me) the incorrect impression that the colour picker is comparing okHSV to okLCH (i.e. that okLRCH is the same as okLCH). I don't think it's fair to assume people landing on this page have read the blog post (let alone in detail). As okHSV gains traction there are going to be more people, who like me, found about okHSV from other sources, and are arriving at the tool without the context about LR. It should be clear this is a variant of okLCH with different luminence values. Thank you! :)